Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored HandManager and Added comprehensive test coverage for HandManager #135

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

Grimmblood
Copy link
Contributor

@Grimmblood Grimmblood commented Apr 24, 2024

Describe your changes

Commented out the debug tools of HandManager, as well as removed some now unused methods.
Added Comprehensive test coverage for HandManager.

Issue number and link

N/A

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (fixes a issue)
  • New feature (new implemention of a feature)
  • Refactoring (small changes that won't impact very much)
  • Possible broken change (fix or feature that could break functionality)

Checklist:

  • Have added comments and documentation
  • You have tested all the code thoroughly
  • I have added tests to cover my changes.
    Or have added an issue that tests need to be added.
  • If scene changes were made were they in a separate scene (Doesn't apply to CodingAdam)

@Grimmblood Grimmblood added the test coverage improve or add tests label Apr 24, 2024
Copy link
Contributor

@CodingAdam CodingAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks for the screenshot, gives a good idea of what works. This should help a lot with coverage and 7 lines is fine if we can't get those.

Copy link
Contributor

@GNAR1ZARD GNAR1ZARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving hot fix for coverage increase due to deadline --no conflict/flag.

@GNAR1ZARD GNAR1ZARD merged commit eb3b117 into UNLV-CS472-672:master Apr 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test coverage improve or add tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants