Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing coverage #140

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Testing coverage #140

merged 2 commits into from
Apr 24, 2024

Conversation

CodingAdam
Copy link
Contributor

Describe your changes

Fixed a bunch of random testing cases

  • AttackButton
  • CancelButton
  • BuildButton
  • EndTurn
  • WinConditions
  • EscapeMenu

Issue number and link

N/A

Screenshots (if appropriate):

Too many

Types of changes

  • Bug fix (fixes a issue)
  • New feature (new implementation of a feature)
  • Refactoring (small changes that won't impact very much)
  • Possible broken change (fix or feature that could break functionality)
  • Test Coverage

Checklist:

  • Have added comments and documentation
  • You have tested all the code thoroughly
  • I have added tests to cover my changes.
    Or have added an issue that tests need to be added.
  • If scene changes were made were they in a separate scene (Doesn't apply to CodingAdam)

@CodingAdam
Fixed Coverage
a49fc01 
- Win Conditions
- Attack Button
- Build Button
- Cancel
- End turn
@CodingAdam
Fixed Escape Menu
3358bbc
Super-Spicy-Ramen
Super-Spicy-Ramen approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Super-Spicy-Ramen Super-Spicy-Ramen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job increasing code coverage with thorough testing. Approving.

Grimmblood
Grimmblood approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Grimmblood Grimmblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can finalize DP3

@Super-Spicy-Ramen Super-Spicy-Ramen merged commit 412f29f into UNLV-CS472-672:master Apr 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Super-Spicy-Ramen Super-Spicy-Ramen Super-Spicy-Ramen approved these changes

@Grimmblood Grimmblood Grimmblood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodingAdam @Grimmblood @Super-Spicy-Ramen