Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd Checklist and fix typo in pr template #144

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

CodingAdam
Copy link
Contributor

Describe your changes

Readded the checklist, looks it got accidentally removed at some-point.

Issue number and link

N/A

Screenshots (if appropriate):

Types of changes

  • Bug fix (fixes a issue)
  • New feature (new implementation of a feature)
  • Refactoring (small changes that won't impact very much)
  • Possible broken change (fix or feature that could break functionality)

Checklist:

  • Have added comments and documentation
  • You have tested all the code thoroughly
  • I have added tests to cover my changes.
    Or have added an issue that tests need to be added.
  • If scene changes were made were they in a separate scene (Doesn't apply to CodingAdam)

Copy link
Contributor

@GNAR1ZARD GNAR1ZARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job adding that mandatory file and updating the template. Approving

Copy link
Contributor

@Grimmblood Grimmblood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for finalizing DP3

@Grimmblood Grimmblood merged commit b3de72d into UNLV-CS472-672:master Apr 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants