Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include GENUNITS table from mms #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dec-heim
Copy link

@dec-heim dec-heim commented Dec 6, 2022

Request/update to include GENUNITS table from mms, in particular to allow users to access 'CO2E_EMISSIONS_FACTOR' for a specified date range.

Suggested commits are setup to remove duplicated rows on primary keys: ['GENSETID', 'LASTCHANGED','CO2E_EMISSIONS_FACTOR']. This way the user can also clearly see different assumptions for CO2 factors updated overtime from NTNDP/ISP in 'CO2E_DATA_SOURCE' col

  • Inclusion of 'GENUNITS' in defaults.py
  • Inclusion of 'GENUNITS' in processing_info_maps.py

includes GENUNITS table in defaults.py
include GENUNITS table in processing_info_maps.py
Copy link
Contributor

@prakaa prakaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signing off but some things to consider:

  1. The filter function used by this table is untested (though relatively simple). We will need to add tests:

image

2. Guidance on table use would be good to document. As you suggested, might be best to have this as a wrapper func in `NEMED` @dec-heim. Ideally, links to the various sources are included in docs:

image

3. Wiki needs to be updated

@mlee94 mlee94 mentioned this pull request Jan 8, 2023
@dec-heim
Copy link
Author

For those interested... this functionality for GENUNITS + DUALLOC is used in and also available via the package NEMED.
See https://github.com/UNSW-CEEM/NEMED/blob/master/src/nemed/downloader.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants