This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
1165-incompatible-browser-validation-and-warning #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@briandavidson - Hey Brian, just a heads up. I sent you a message detailing multiple questions and problems I'm having with the current PRs en queue. Gratsi sir! |
briandavidson
suggested changes
Jun 11, 2020
|
@briandavidson @mtlaney - Hey Mike and Brian, this PR should be good for a final review. |
briandavidson
suggested changes
Jun 23, 2020
Dmac26
requested review from
briandavidson and
mtlaney
and removed request for
mtlaney
mtlaney
approved these changes
Jun 26, 2020
mtlaney
approved these changes
Jun 29, 2020
Dmac26
requested review from
briandavidson
and removed request for
briandavidson
briandavidson
approved these changes
Jul 1, 2020
Comment on lines
+102
to
+115
| switch (parsedBrowserInfo[1]) { | ||
| case 'OPR': { | ||
| this.browserName = 'Opera'; | ||
| break; | ||
| } | ||
| case 'Edge': { | ||
| this.browserName = 'Edge'; | ||
| break; | ||
| } | ||
| default: { | ||
| this.browserName = 'notChrome'; | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
This switch is much cleaner, nice work here @Dmac26!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Issue # 1165
This PR is an updated version of the original 1165 PR, which needed several styling updates to account for mobile views and to clean up some syntax. I was unable to directly update the original PR as I did not manage my work flow properly and my branch was significantly behind the dev branch.
This pull request is ready to merge when...