-
Notifications
You must be signed in to change notification settings - Fork 19
1206-Phone-Number-Error-and-Hint-Text-Post-Circle-PR #1358
1206-Phone-Number-Error-and-Hint-Text-Post-Circle-PR #1358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good and clean. I would revert or omit changes to package-lock.json and package.json, it appears to be trying to upgrade a bunch of stuff we don't need right now, and will cause errors with webdriver trying to build and run the tests in Jenkins.
@mtlaney - Hey Mike, I went ahead and reverted the .json file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @mtlaney stated, please revert the changes to package.json
and omit package-lock.json
.
After that's addressed, and the minor issue with allowing the user to type more than 10 characters, this should be g2g.
@mtlaney @briandavidson - This one should be good to go too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks g2g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
g2g
Summary
Addresses Issue # 1165
This PR is an updated version of the original 1165 PR, which needed several styling updates to account for mobile views and to clean up some syntax. I was unable to directly update the original PR as I did not manage my work flow properly and my branch was significantly behind the dev branch.
This pull request is ready to merge when...