Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Fixed Sonarqube code smells, vulnerabilities and bugs #1360

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Fixed Sonarqube code smells, vulnerabilities and bugs #1360

merged 2 commits into from
Jun 4, 2020

Conversation

abdul-fs
Copy link
Contributor

@abdul-fs abdul-fs commented Jun 4, 2020 •
edited
Loading

Fixed code smell for sonarqube.

This pull request is ready to merge when...

  • Feature branch is starts with the issue number
  • Is connected to its original issue via zenhub 👇
  • Tests have been updated
  • All tests are passing and meet coverage, linting, and accessibility requirements. And no security vulnerabilities ⚫️(Circle)
  • Server actions captured by logs (manual)
  • Documentation / readme.md updated (manual)
  • API docs updated if need (manual)
  • JSDocs updated (manual)
  • This code has been reviewed by someone other than the original author

@abdul-fs abdul-fs requested review from mtlaney and mwreiss June 4, 2020 15:08
mtlaney
mtlaney approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@mtlaney mtlaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

g2g!

@abdul-fs abdul-fs merged commit a7543a3 into dev Jun 4, 2020
@abdul-fs abdul-fs mentioned this pull request Jun 10, 2020
Merged
6 tasks
@kilara77 kilara77 deleted the sonarqubefixes branch October 23, 2020 04:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtlaney mtlaney mtlaney approved these changes

@mwreiss mwreiss Awaiting requested review from mwreiss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdul-fs @mtlaney @kilara77