Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

cancelling christmas on prod #1508

Merged
merged 3 commits into from
Nov 3, 2020
Merged

cancelling christmas on prod #1508

merged 3 commits into from
Nov 3, 2020

Conversation

mtlaney
Copy link
Contributor

@mtlaney mtlaney commented Oct 28, 2020

Summary

Addresses Issue #1355

Please note if fully resolves the issue per the acceptance criteria: Yes

This PR is to only move the changes in DEV/STAGING to prod to encompass ONLY the Christmas tree removal

Impacted Areas of the Site

  • /christmas-trees/forests
  • /christmas-trees/forests/id
  • /christmas-trees/forests/applications/id

Optional Screenshots

Screen Shot 2020-10-28 at 5 58 46 PM

This pull request changes...

  • Christmas Tree routing
  • Christmas Tree UI Display

This pull request is ready to merge when...

  • Feature branch is starts with the issue number
  • Tests have been updated
  • All tests are passing and meet coverage, linting, and accessibility requirements. And no security vulnerabilities ⚫️(Jenkins)
  • This code has been reviewed by someone other than the original author

Copy link
Contributor

@mwreiss mwreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mtlaney need @abdul-fs to get an SIA in place and have him push this to Master once approved by Jon.

@abdul-fs
Copy link
Contributor

abdul-fs commented Nov 2, 2020

@JonathanLerner54 Sent SIA for this release.

@JonathanLerner54
Copy link

Some one still needs to check all the boxes for completion criteria.

@JonathanLerner54
Copy link

SIA has been completed and archived in Pinyon folder: \Box\ePermits\SOP\ePermits Releases\FY2021\FY21 ePermits Release to Production 1508

@abdul-fs
Copy link
Contributor

abdul-fs commented Nov 2, 2020

@JonathanLerner54 @mtlaney thanks jon. should be good to push in production today with updated release notes.

@abdul-fs abdul-fs requested a review from mwreiss November 2, 2020 20:40
Copy link
Contributor

@mwreiss mwreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike! Looks good

@abdul-fs abdul-fs merged commit 63d0a20 into master Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants