WRF-CMAQ Bugfix for UWIND and VWIND at Grid Cell Centers (mass points) #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in creating u and v components. modified: twoway_aqprep.F90
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contact:
David Wong US EPA
Type of code change:
bug fix
Description of changes:
This bugfix only impacts the WRF-CMAQ coupled model, it does not impact any model runs done using retrospective meteorology processed through MCIP.
Fixed a bug in creating u and v components at mass points by removing the following two lines
metcro3d_data_wrf (:,:,1:nlays,15) = zf (:,:,1:nlays)
metcro3d_data_wrf (:,:,1:nlays,16) = zf (:,:,1:nlays)
which overwrote the proper calculations:
metcro3d_data_wrf (c,r,kk,15) = grid%u_phy(ii,kk,jj) ! store u wind component on mass point
metcro3d_data_wrf (c,r,kk,16) = grid%v_phy(ii,kk,jj) ! store v wind component on mass point
Issue:
N/A
Summary of Impact:
Wind u and v components at mass points were incorrectly represented by level high. This bug impacts the wind speed calculations at the mass points (i.e., cell centers). All processes that use the wind speeds at the mass points in the WRF-CMAQ coupled model will be impacted.
Tests conducted:
A one day test was conducted based on the NE 2018 Benchmark dataset. Here are some snapshot of the difference (new - old) with respect to four variables: O3, ASO4J, SWDOWN, and T2.