Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contributing.md #111

Merged
merged 2 commits into from
Aug 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions .github/workflows/pkgdown.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
push:
branches: [develop]
branches: [main, master]
pull_request:
branches: [develop]
branches: [main, master]
release:
types: [published]
workflow_dispatch:
Expand Down Expand Up @@ -44,9 +44,3 @@ jobs:
clean: false
branch: gh-pages
folder: docs

url: https://usepa.github.io/TADA/

template:
bootstrap: 5
bootswatch: cerulean
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ GitHub is a third-party website that offers version-controlled repositories that

- To contribute a specific change or new code, outside contributors can create a new branch or fork this repo from the **develop** branch, then create a pull request for us to review.

All new development currently happens in the **develop** branch. When the code is polished and ready for testing, it moves to the **staging** branch. The **main** branch is reserved for finalized code. To contribute a specific change or new code, outside contributors can create a new branch or fork this repo from the **develop** branch, then create a pull request for us to review.
All new development currently happens in the **develop** branch. To contribute a specific change or new code, outside contributors can create a new branch or fork this repo from the **develop** branch, then create a pull request for us to review.

Each contributor should work in a new, separate branch for each task. When the task is complete, the contributor can create a pull request for changes to be merged. We will review the contribution and delete the branch once the merge is complete. GitHub best practice is to not reuse branches after merge is requested via a pull request.

Complete the pull request by detailing all fixes and contributions, and tagging TADA repo admins who should review the work. For this package, please tag cristinamullin (Cristina Mullin) and mthawley (Shelly Thawley).

Repository Administrators will review code contributions from external collaborators and integrate code commits into source code. This is done to ensure code stability and consistency and prevent degradation of code performance. After review, the admin will either accept the submission, recommend specific improvements to the submission, or in some cases reject the submission. To avoid outright rejection, developers contributing code should contact the Repository Administrator early in the development process and maintain contact throughout to help ensure the submission is compatible with the code base and is a robust addition.
Repository Administrators will review code contributions from external collaborators and integrate code commits into source code. This is done to ensure code stability and consistency and prevent degradation of code performance. After review, the admin will either accept the submission, recommend specific improvements to the submission, or in some cases reject the submission. To avoid issues, developers contributing code should contact the repository admins (Cristina or) early in the development process and maintain contact throughout to help ensure the submission is compatible with the code base and is a robust addition.

## More Information

Expand All @@ -46,4 +46,4 @@ The EPA specific implementation of OMB Mandate M-16-21 is addressed in the [Syst

## License

All contributions to this project will be released under the CCO dedication. By submitting a pull request or issue, you are agreeing to comply with this waiver of copyright interest.
All contributions to this project will be released under the MIT + CCO file license dedication. By submitting a pull request or issue, you are agreeing to comply with this waiver of copyright interest.