update staging #180
Merged
update staging #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made minor edits to correct grammar mistakes in CONTRIBUTING vignette.
Made minor edits to correct grammar mistakes in WQPDataHarmonization vignette.
Added example to InvalidFraction function in ResultFlagsDependent.R
Vignettes proofreading kh
InvalidFraction example
Added examples to functions in ResultFlagsDependent, ResultFlagsIndependent, Transformations (except HarmonizeCensoredData and CensoredDataStats), and Filtering.
Updated QAPPapproved function to add warning for when clean & cleanNA are FALSE. Also updated examples for QAPPDocAvailable function to improve clarity.
Added comments to examples for functions: ResultFlagsDependent.R, ResultFlagsIndependent.R, Transformations.R (except HarmonizeCensoredData and CensoredDataStats), and Filtering.R.
Added more co-author information. Changed "assessment" to "analysis" in TADA
Added examples to completed functions
small changes
Added an "errorsonly" parameter to InvalidFraction() which filters data to show only the invalid characteristic-fraction combinations when errorsonly = TRUE.
using devtools to update internal package documentation
Updated functions in ResultFlagsDependent.R and ResultFlagsIndependent.R to include option to review only flagged data via "errorsonly" parameter. (Note: haven't finished updating ResultFlagsIndependent.R functions)
fixes warning related to example of HarmonizeData() function didn't have a "ref" input; however, the documentation states this would be an optional argument - function may need to be updated so that checkType(ref, "data.frame") only happens if a reference table is provided
Update ResultFlagsDependent.R
Added lat and long conversion to class numeric to autoclean
Changed clean_outsideUSA argument in InvalidCoordinates() to accept three options: "no" (default), "remove", or "change sign" to address issue #177
…ates updated fips code reference file to include territories: https://www2.census.gov/geo/docs/reference/state.txt updated vignette and test associated with clean_outsideUSA/Invalidcoordinates update
Added descriptions of errorsonly to all flag functions and added description of clean_outsideUSA inputs.
option to change sign of lat/long outside USA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.