-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State level initial #112
Merged
Merged
State level initial #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initialized code for testing FrEDI
Deleted createSystemData since it is no longer required
…hey can be imported from namespace eventually)
…age cowplot in figure creation
Edited fun_limitsByGroup to work for sector-only grouping Edited get_sector_plotInfo to work for sector-only grouping
Added Y Title, simplified plot code
Added Y Title, simplified plot grid code
Added sector list to scenario code. Edited get_ciraDataObject to be able to be used in nonFrEDI packages.
Updated report figures to test out create_DoW_results function
Moved SLR scenarios figure
Turned script for creating report figures into a function, create_DoW_results
Edited description: removed dplyr, ggplot2, tidyr (which are included in tidyverse) Added ggpubr (which is required for plotting) Added devtools to suggested packages
Renamed create_report_figures and added argument to return the data and plot list
Added code for whether to load the image code from source, package, or project
Changed function pipe to %>%
Added code to specify how to load the image code
Moved greetings GitHub action and initialized actions to build and test FrEDI
Added ORCID IDs for IEc contributers
Initial workflows report figures
File "utils_create_report_figures.R": - Created function `create_fig_scale_note` to create a note for multiple impact types File: "utils_plot_DOW_byImpactTypes.R": - Made note on impact type contingent on multiple impact types and variants File: "create_DoW_results.R": - Set default loadCode to "project"
Deleted files with a reference year of 2050...not applicable to appendix figures
File "utils_report_figures_scales": - If nRow = 0, nRow = 1
File "utils_report_figures_format_sector_names.R": - Created function `repCollapse` to repeat a new line a certain number of times and then collapse it - Changed extra lines to be added all at beginning of sector name
Fixed new line string
File "utils_create_report_figures.R" - Changed functions `sum_impacts_by_DoW` and `sum_impacts_by_DoW_years` and `get_fig7_slrImpacts` to take argument `aggOnly` to determine whether to only include sectors in Figure 7 for which `includeaggregate==1` - Changed function `plot_DoW_by_modelYear` to remove lines of code factoring sectors for labeling...moved lines of code to `utils_plot_DOW_byImpactTypes` - Moved formatting of sector names into `utils_plot_DOW_byModelType` - Fixed years for which plots are printed for Fig7 and appendix figures
change logical in figure area
Changed test0 to tests0 in rm command
Changed which item is returned in the function for creating a summary of results for main FrEDI
Merged changes from main into fix_maintenance
Added line to gitignore to ignore report figures
Commenting out line to ignore report figures until figures successfully deleted from main
… fix_maintenance
Added pipe operator to line 304: tempInput is a data frame, not a function
Fix maintenance: issue with run_fredi line 304
Added step to create report figures directory if it doesn't exist
Added test file to see if report code will run
Fixed small issue with maintenance: tempInput is a data frame, not a function call (line 304 run_fredi). Reviewed test and figure outputs and tests and figures pass.
Removed license from report_figures directory (report_figures directory can eventually be deleted)
Delete LICENSE
Changed some wording in documentation in comments to address comments/requested changes in Pull Request #104
Fixes to function documentation/comments
Added license to main repo directory
Create LICENSE
Maintenance fixes
Made some changes to names used in interpolate_annual
Replaced some magrittR pipe operators with native pipe operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging initial state-level code into the main initial branch