Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phocube, in source=projection should be able to accept a multi-band cube as input #3877

Closed
lavalaz opened this issue May 22, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request Products Issues which are impacting the products group
Milestone

Comments

@lavalaz
Copy link

lavalaz commented May 22, 2020

Description

Adding lat/lon backplanes to a color mosaic would be easier if phocube would accept a multiband input. I think it is reasonable to assume that if the user wants to propagate DNs to the output, they will want to propagate DNs for all the bands. Yes, one can run phocube on a single band and then run cubeit, but, for large mosaics, that adds another slow step. A nice-to-have, not something essential!
Example

enter the following command:
phocube from=some-color-mosaic.cub to=mosaic-with-backplanes.cub source=projection
and you get an output instead on an error message.

@jlaura jlaura added enhancement New feature or request Products Issues which are impacting the products group labels May 22, 2020
@scsides
Copy link
Contributor

scsides commented Aug 31, 2020

@lavalaz phocube currently requires a single band input (defaults to band 1 if not specified using a cube attribute) because some multi-band images are not spatially registered (e.g., Themis IR). line=1, samp=1, band=1 has a different lat/lon then line=1, samp=1, band=2. In your example it is a projected mosaic, so all the bands are spatially registered by definition.

Option:
Add a parameter to phocube to force it to include all DN bands in the output cube and put a big red warning in the documentation to warn users of the possibility the DN bands are not properly represented by the pho bands. Have the default behavior be identical to the way is now, so we don't break existing scripts (backward compatibility).
Additionally, it may be easy or not to add in enough upfront checks to allow this when the output would be correct and fail if not.

@scsides scsides self-assigned this Aug 31, 2020
@scsides
Copy link
Contributor

scsides commented Sep 11, 2020

@lavalaz, What do you think of the solution above?

@lavalaz
Copy link
Author

lavalaz commented Sep 11, 2020

I had not considered the case where phocube might be run on non-map-projected data when I suggested this enhancement. It seems to be a bad idea for cases when the different bands are not spatially registered. But, as a user with a specific need, your solution would work great for me. I am trying hard to imagine the trouble other users might get themselves into if this option exists and I am inclined to feel that the warning in the documentation should suffice. A lot of words to say I like the idea!

@github-actions
Copy link

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.

@github-actions github-actions bot added the inactive Issue that has been inactive for at least 6 months label May 26, 2021
@jessemapel jessemapel removed the inactive Issue that has been inactive for at least 6 months label May 26, 2021
@jessemapel
Copy link
Contributor

This is on the current support backlog

@AustinSanders AustinSanders added this to the 6.1.0 milestone Aug 5, 2021
@AustinSanders AustinSanders modified the milestones: 6.1.0, 6.2.0 Oct 20, 2021
@jlaura jlaura moved this to In Progress in ASC Software Support Nov 11, 2021
@jlaura jlaura removed the status in ASC Software Support Nov 15, 2021
@jlaura jlaura moved this to In Progress in ASC Software Support Nov 15, 2021
@jlaura jlaura moved this from In Progress to Done in ASC Software Support Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Products Issues which are impacting the products group
Projects
None yet
Development

No branches or pull requests

5 participants