Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cnetcombinept log file logs everything, not just merged points #4973

Closed
lwellerastro opened this issue Jun 16, 2022 · 1 comment
Closed

Cnetcombinept log file logs everything, not just merged points #4973

lwellerastro opened this issue Jun 16, 2022 · 1 comment
Assignees
Labels
bug Something isn't working Products Issues which are impacting the products group

Comments

@lwellerastro
Copy link
Contributor

ISIS version(s) affected: tested under 5.0.2 but also broke in newer versions of isis

Description
The log includes an entry for all points in the output network when it should only include entries for points that were merged.
It makes it very difficult to identify which points have new measures that require registration for extremely large networks.

How to reproduce
See my work users area directory Isis3Tests/CnetCombinePt/Log

cnetcombinept cnetlist=nets.lis onet=TestCombinePt10.net logfile=TestCombinePt10.log networkid=Island25 description="GLL SSI Merge Island25 to Island1, 8 and 9" imagetol=10

  Group = Summary
    TotalCubes        = 29
    TotalInputPoints  = 43
    TotalOutputPoints = 40
    PointsMerged      = 3
    PointsEvaluated   = 3
    TotalMeasures     = 99
    MeasuresMerged    = 2
    MeasuresDeleted   = 0
    MinimumMeasures   = 0
  End_Group

I expect the log to include information on the 2 measures that were merged, at least according documentation.

wc -l TestCombinePt10.log
41 TestCombinePt10.log

Additional context
I came across this while combining two very large networks that have a few hundred overlapping images but many hundreds of thousands of points each. The newly combined network has >750k points but only 5500 points were merged. I need to register measures only for the newly merged points and that will go quicker if I can identify those points, extract them, then register them. This is for the Kaguya TC project and a working log will be much easier to work with to generate a list of points register, than say running cnetstats on the input and output networks and making comparisons and differences of the point statistics files to identify those same points (or some other similar yet cumbersome way).

@lwellerastro lwellerastro added bug Something isn't working Products Issues which are impacting the products group labels Jun 16, 2022
@AustinSanders AustinSanders self-assigned this Jul 5, 2022
@AustinSanders AustinSanders moved this to In Progress in FY22 Q4 Support Jul 5, 2022
@AustinSanders AustinSanders moved this from In Progress to Needs Review in FY22 Q4 Support Jul 6, 2022
@AustinSanders
Copy link
Contributor

Closed via #4984

Repository owner moved this from Needs Review to Done in FY22 Q4 Support Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Products Issues which are impacting the products group
Projects
None yet
Development

No branches or pull requests

2 participants