Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

Explicitly state agreed upon DRB partitions (years, segments) in readme? #162

Open
jsadler2 opened this issue Jan 25, 2022 · 7 comments
Open

Explicitly state agreed upon DRB partitions (years, segments) in readme? #162

jsadler2 opened this issue Jan 25, 2022 · 7 comments

Comments

@jsadler2
Copy link
Collaborator

Somewhere (maybe in the readme), we should explicitly state the baseline run conditions we've all agreed upon across projects (partition years, segments)

Originally posted by @SimonTopp in #148 (comment)
@jsadler2
Copy link
Collaborator Author

I did not include this in #148 because I'm not actually sure it belongs in this repo. In my understanding the partitions are narrower in spatial and variable-of-interest scope of river-dl. I see the partitions applying only to the DRB and to water temperature. But river-dl could be applied to a river network (or non-river network) anywhere and to any variable. So I'm actually in favor of either not stating those agreed-upon partitions in the river-dl documents OR doing it in a way that communicates that this is just one group's decision. Maybe it would go in it's own file like DRB_temp_partitions.md so that we have it for reference, but we aren't suggesting that everyone use those splits.

@SimonTopp
Copy link
Contributor

I see what you're saying. This seems somewhat related to the "does all the work for a few people vs does some work for lots of people discussion". Given that we're generally moving towards the latter, I think I'm fine leaving it out since it only applies to a handful of folks. @janetrbarclay, what do you think? I'm good closing this issue if you agree.

@janetrbarclay
Copy link
Collaborator

I'm not sure where it should be (and agree that maybe the main readme isn't the place), but it does seem useful to document somewhere (other than in a string of emails :) ) the baseline conditions we're using. This seems especially useful as we start having others work on the various temperature projects.

@jdiaz4302
Copy link
Collaborator

This seems especially useful as we start having others work on the various temperature projects.

This was really helpful for me on the reservoir project - https://github.com/USGS-R/delaware-model-prep/blob/main/test_train_split/explanation_test_set.md. There's also some slides somewhere explaining why they chose the years (e.g., why they're discontinuous) that I can't find right now...

@janetrbarclay
Copy link
Collaborator

janetrbarclay commented Feb 24, 2022 via email

@jdiaz4302
Copy link
Collaborator

Yep, those!

@janetrbarclay
Copy link
Collaborator

janetrbarclay commented Feb 24, 2022 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janetrbarclay @jsadler2 @jdiaz4302 @SimonTopp