Feature support human tasks with completely custom camunda forms #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store all variables if no variable is explicity marked as workflow result.
PhilWun
reviewed
Feb 28, 2024
| raise # otherwise reraise | ||
|
|
||
| if not form_is_embedded: | ||
| # Extract form variables from the rendered form. Cannot use only camunda endpoint for form variables (broken) # TODO link issue |
stable_plugins/workflow/workflows/templates/workflow_human_task.html
Outdated
Show resolved
Hide resolved
| type: "form-submit", | ||
| formData: (new URLSearchParams(formData)).toString(), | ||
| formDataType: "application/x-www-form-urlencoded", | ||
| dataInputs: [], // TODO |
There was a problem hiding this comment.
This is a hard problem, and it is unlikely that an external form even takes QHAna data inputs. So I would just leave this as a TODO.
| } | ||
| }); | ||
| } | ||
| // TODO: show error message to user for else case... |
| }); | ||
| }); | ||
| } | ||
| // TODO: show error message to user for else case... |
| canvas.zoom('fit-viewport'); | ||
| }); | ||
| } | ||
| // TODO: show error message to user for else case... |
|
I removed one todo, the rest are either old todos or just a time sink with little to gain (or both). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.