-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature support human tasks with completely custom camunda forms #116
base: main
Are you sure you want to change the base?
Conversation
Store all variables if no variable is explicity marked as workflow result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few todo comments. You decide whether they should be addressed before merging or later on.
raise # otherwise reraise | ||
|
||
if not form_is_embedded: | ||
# Extract form variables from the rendered form. Cannot use only camunda endpoint for form variables (broken) # TODO link issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo comment
stable_plugins/workflow/workflows/templates/workflow_human_task.html
Outdated
Show resolved
Hide resolved
type: "form-submit", | ||
formData: (new URLSearchParams(formData)).toString(), | ||
formDataType: "application/x-www-form-urlencoded", | ||
dataInputs: [], // TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a hard problem, and it is unlikely that an external form even takes QHAna data inputs. So I would just leave this as a TODO.
} | ||
}); | ||
} | ||
// TODO: show error message to user for else case... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo comment
}); | ||
}); | ||
} | ||
// TODO: show error message to user for else case... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo comment
canvas.zoom('fit-viewport'); | ||
}); | ||
} | ||
// TODO: show error message to user for else case... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo comment
I removed one todo, the rest are either old todos or just a time sink with little to gain (or both). |
No description provided.