Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect albedo reported over lakes #419

Closed
tbohn opened this issue Mar 24, 2016 · 5 comments
Closed

Incorrect albedo reported over lakes #419

tbohn opened this issue Mar 24, 2016 · 5 comments
Assignees
@tbohn
Labels
bug vic_run
Milestone
5.0

Comments

@tbohn
Copy link
Contributor

tbohn commented Mar 24, 2016

VIC's internally-used albedo over lakes is fine. But it isn't being reported correctly in output files. This won't affect results in any way (except for reported albedos). The fix is trivial - a one-liner.
@jhamman
Copy link
Member

jhamman commented Mar 24, 2016

So is the problem in put_data or somewhere in vic_run?

@tbohn
Copy link
Contributor Author

tbohn commented Mar 24, 2016

It's in vic_run, in lakes.eb.c.

@jhamman jhamman added this to the 5.0 milestone Mar 24, 2016
@jhamman
Copy link
Member

jhamman commented Mar 24, 2016

Okay, let's fix this for 5.0, but after we have the test suite put together so we can demonstrate the change.

@tbohn
Copy link
Contributor Author

tbohn commented Mar 24, 2016

Sure.

This was referenced Mar 24, 2016
Closed
Merged
@tbohn
Copy link
Contributor Author

tbohn commented Apr 9, 2016

This was addressed in PR #425 and can be closed

@jhamman jhamman closed this as completed Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbohn tbohn

Labels
bug vic_run
Projects
None yet
Milestone
5.0
Development

No branches or pull requests
2 participants
@jhamman @tbohn