Miscellaneous lake fixes #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lake temperatures.
Pulling in recent updates to travis builds.
|
No problems with the code changes. We need to add a comment in the Release Notes describing the bugs fixed here. |
|
Should that be included in this PR? |
|
Yes, doc and code changes go together. |
|
@tbohn : you're out of date on this one - please merge |
This was referenced Apr 9, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses several minor bugs. Several lake processes (aerodynamic resistance, albedo, latent/sensible heat fluxes, net radiation, etc) were reported incorrectly or not at all in output files. The fixes for those were all minor (1-liners). Lake temperatures were initialized to unrealistic temperatures in the absence of an initial state file. The fix for that was a little more involved: replaced the use of first step's air temperature with use of annual average soil temperature.
closes #405
closes #406
closes #419
closes #420