Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vic_sample_data submodule #387

Merged
merged 18 commits into from
Mar 24, 2016
Merged

add vic_sample_data submodule #387

merged 18 commits into from
Mar 24, 2016

Conversation

jhamman
Copy link
Member

@jhamman jhamman commented Feb 8, 2016

This submodule currently points to https://github.com/jhamman/VIC_sample_data. If we go this route, we'll transfer ownership to UW-Hydro.

@bartnijssen
Copy link
Member

@jhamman : Is this a test or do you want me to review and merge this?

@jhamman
Copy link
Member Author

jhamman commented Feb 9, 2016

I have a bit more work to do before I merge. I need to add the classic driver equivalent and want to tie the 10-day tests in with Travis. I'll ping you when it's ready.

@bartnijssen
Copy link
Member

@jhamman : Just seeing if this is still open

@jhamman
Copy link
Member Author

jhamman commented Mar 17, 2016

Still open. I'll check in with @yixinmao today to see how/if this has been working for her. I know @wietsefranssen had some issues using the image driver setup out of the box so I think I need to refine a few of the pieces.


# save a few directory names
CWD=$PWD
SAMPLES="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does ${BASH_SOURCE[0]} get set?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the full path of this file. (e.g. /home/VIC/samples/get_sample_data.bash)

@jhamman
Copy link
Member Author

jhamman commented Mar 24, 2016

okay, this is ready to go. will merge on green.

@jhamman jhamman added this to the 5.0 milestone Mar 24, 2016
@jhamman jhamman merged commit 302a904 into UW-Hydro:develop Mar 24, 2016
@jhamman jhamman deleted the feature/sample_datasets branch March 24, 2016 23:44
2. More will be added soon!

## Getting the Datasets:
The VIC sample datasets are in a "git submodule", to download the datasets to this directory, simply run the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first comma -> period (right?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants