Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update write_data.c for binary output when OUTPUT_FORCE=TRUE #393

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

lizaclark
Copy link

dmy structure is NULL if OUTPUT_FORCE option is TRUE; thus, dmy->year, etc. cannot be accessed in write_data.c

@jhamman
Copy link
Member

jhamman commented Feb 26, 2016

The question I have is why is dmy null. It should have been populated when mtclim was being run...?

@jhamman jhamman added the bug label Feb 26, 2016
@lizaclark
Copy link
Author

dmy isn't passed to write_forcing_file.c, so write_forcing_file.c creates a dummy_dmy = NULL; to pass into write_data.c (the program that feeds atmos_data_struct variables to out_data_struct), presumably because VIC doesn't write the time when writing forcing output.

@jhamman
Copy link
Member

jhamman commented Mar 8, 2016

I'm fine with merging this. Since we're pretty close to the VIC 5 release, I'd like to hold off on releasing 4.2.d until just before we release 5.0. 4.2.d will then be the basis for the VIC 4 support branch.

@bartnijssen
Copy link
Member

@jhamman : OK - so I will leave this one open for you to merge

jhamman pushed a commit that referenced this pull request Mar 17, 2016
Update write_data.c for binary output when OUTPUT_FORCE=TRUE
@jhamman jhamman merged commit bdd64b5 into UW-Hydro:master Mar 17, 2016
@jhamman
Copy link
Member

jhamman commented Mar 17, 2016

Thanks @lizaclark!

@jhamman jhamman added this to the 4.2.d milestone Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants