Fixing a problem with image restarts when using multiple processors #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an if statement so that when VIC is run on multiple nodes, only the master node will validate state file dimensions and coordinate variables.
Use multiple processors for image restart tests
hhelgason
pushed a commit
to hhelgason/VIC
that referenced
this pull request
Oct 6, 2016
(Fixing a problem with image restarts when using multiple processors).
jhamman
pushed a commit
that referenced
this pull request
Oct 6, 2016
jhamman
pushed a commit
that referenced
this pull request
Jan 6, 2017
* update command line usage docs * update release notes * Fixed image driver history file name (#635) * Fixed image driver history file name timetamp - now is timstep-beginning * Added release notes about PR #635 (fixing image driver history filename timestamp) * Committing a fix to vic_restore.c Added an if statement so that when VIC is run on multiple nodes, only the master node will validate state file dimensions and coordinate variables. * Use multiple processors for image restart tests * dummy forcings are now created while initializing the model prior to communicating with the coupler * removed decimal point for missing value for unsigned ints * initial fix for getting state file date/time info * updated fix for getting statefile time info from dmy_current (period-ending) * Fixed a bug when calculating steps of forcing to skip (#639) * Fixed a bug when calculating steps of forcing to skip - should round to integer first before converting to int type to prevent possible 1-timestep wrong offset * Added bug fix release notes to PR#639 * fixed bug that passed fillvalue as double when it was supposed to be an int in gather_put_nc_field_int fctn * Added release notes about PR #638. (#640) (Fixing a problem with image restarts when using multiple processors). * use appropriate fillvalue datatypes in gather_put_nc_field fctns * add caseid to statefile name by passing case metadata in to vic_cesm_run function * Revert "add caseid to statefile name by passing case metadata in to vic_cesm_run function because adding this logic to vic_cesm_init instead" This reverts commit 7e28f13. * assign caseid to statefile name in vic_cesm_init * fix warnings for SNOW_BAND and AGGFREQ * fixed typo in comment * Added check to ensure mask variable in the input domain file is integer type (#645) * Added check to ensure mask varible in domain file is integer type * Cleaned up some printing lines * Added get_nc_var_type.c * Minor update of comments and ReleaseNotes * Added domain file description in docs * Small fix of table in docs * Added ncdump -h results for domain file in docs * Minor docs update * fix typo in primary reference (#646) * Fix bug make lastday (#647) * Added check to ensure mask varible in domain file is integer type * Cleaned up some printing lines * Added get_nc_var_type.c * Minor update of comments and ReleaseNotes * Added domain file description in docs * Small fix of table in docs * Added ncdump -h results for domain file in docs * Minor docs update * The input arguments to function `make_lastday` are sometimes in a wrong order - fixed the bug * Added ReleaseNotes regarding PR#647 * Revert "Merge branch 'hotfix/5.0.1' of github.com:UW-Hydro/VIC into hotfix/5.0.1" This reverts commit a9a202b, reversing changes made to bbf7d9a. * pressure was being converted to kPa, should be in Pa * Revert "pressure was being converted to kPa, should be in Pa" This reverts commit 72a56a5. * pressure was being converted to kPa, should be in Pa * convert pressure to kPa when reading it in rather than Pa since this was updated in VIC 5 * Revert "convert pressure to kPa when reading it in rather than Pa since this was updated in VIC 5" This reverts commit e7192c5. * fixed bug with using the correct local domain grid cells and units issues * address PR review comments * add change log entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with image restarts when using multiple processors. Edits were made to the vic_restore.c script to ensure that only the master node validates state file dimensions and coordinate variables. Multiprocessing was also added to a VIC Testing script.