Improve Q12 calculation #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 15, 2016 23:15
numerical solution) in order to avoid unreasonably-strong soil moisture oscilation when the Brook & Corey curve is steep
jhamman
reviewed
Jan 5, 2017
There was a problem hiding this comment.
I have no comments on this change. Syntax and style look fine. I'll leave it up to @bartnijssen to assess the correctness of the implemented algorithm since he's been working with you on the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drainage from upper layer to adjacent lower layer is calculated by Brook & Corey curve (where drainage rate is a function of upper-layer soil moisture). Before this PR, a simple numerical solution is applied which uses the timestep-beginning upper-layer soil moisture to calculate drainage rate, and assume this constant rate over the entire timestep. This can cause unreasonably large drainage if the curve has a steep shape and when soil moisture is high.
This PR modify layer drainage (Q12) calculation - use exact integral (instead of numerical solution) in order to avoid unreasonably-strong soil moisture oscilation when the Brook & Corey curve is steep.
This PR should close issue #655