pass gridcell averaged albedo from all_vars struct to wrf #718
Conversation
There was a problem hiding this comment.
Looks good to me. @bartnijssen can merge if this makes sense to him.
|
We should hold off on merging this until I address the issue that @bartnijssen and I were looking at yesterday (we need to be passing weighted veg or snow albedos when shortwave is zero). I am going to see if I can do this before I leave tomorrow for vacation. |
|
@jhamman and @bartnijssen this is ready for another review. |
|
@dgergel - can you post a few figures that demonstrate the behavior of this version of the code? |
|
@jhamman I've just posted a bunch of figures in the RASM slack channel showing this. |
…gel/VIC into feature/update_albedo_passed_to_wrf
|
Some figures that demonstrate the behavior of this version of the code (note that this PR includes changes to both cold start albedo and how we're calculating albedo at each time step, so I'm including figures for both): First timestep (colorbar ranges not set so that the full ranges are clear): VIC5 Second timestep (VIC5 colorbar set to VIC 4 colorbar min and max): Third timestep: |
…tly to vic_populate_model_state in each driver-specific version
|
@jhamman all done. This should be ready to merge. |
closes #xxxnew tests addedscience test figuresThis quick PR is a follow-up to #712 and #710 so that the
cesm_put_data.croutine in the CESM driver passes gridcell-averaged albedo to WRF.