Feature/fix remaining coupler fields #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartnijssen
approved these changes
Aug 18, 2017
|
Just a few figures to show the turbulent heat flux changes and evaporation changes; these figures are from an RBR run that ran until the debug queue walltime was up, so the figures are from the last timestep before that (from Sept 1 1979). Colorbars are not constrained to show the full ranges for both.
|
jhamman
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the signs for evaporation (
l2x_Fall_evap), latent heat (l2x_Fall_lat) and sensible heat (l2x_Fall_sen). Sign conventions now agree with those for coupled models (before we'd switched them back to agree with the image driver, which was incorrect).closes #xxxnew tests addedscience test figures