Feature/update organic fract option #837
Conversation
| d3start, d3count, dvar); | ||
| for (i = 0; i < local_domain.ncells_active; i++) { | ||
| soil_con[i].bulk_dens_org[j] = (double) dvar[i]; | ||
| } |
There was a problem hiding this comment.
what happens if BULK_DENSITY_COMB == True? Are you sure we're parsing BULK_DENSITY_COMB and ORGANIC_FRACT properly from the global parameter file?
There was a problem hiding this comment.
@jhamman yes. If BULK_DENSITY_COMB == True, then we read in the combined bulk density (mineral and organic) from the parameter file rather than reading in the organic bulk density separately.
What I don't know is to what extent reading in the combined bulk density changes soil temperatures vis-a-vis turning on the ORGANIC_FRACT option, but I could test that and I think it would be useful to understand. Reading in the combined bulk density without turning on ORGANIC_FRACT definitely impacts soil temperatures. As @bartnijssen and I have discussed, the bulk density is used throughout the frozen soils routine, so just using the combined bulk density without turning on ORGANIC_FRACT is already incorporating the organic content of the soil into the thermal conductivity calculations.
There was a problem hiding this comment.
Would be good to see a test. Can be done for a single grid cell.
|
I just made an issue for doing some follow-up analysis that will look at the impact on soil temperatures of turning on the |
|
@dgergel : If you resolve the conflict then I can merge |
|
@bartnijssen resolved the conflict earlier, this should be ready to merge |
This PR enables the
ORGANIC_FRACToption to be turned on in VIC 5 (it was tested as part of this PR) and also enables theBULK_DENSITY_COMBoption to be used in conjunction with it.