This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Mw integration #19
Merged
Mw integration #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param searchTerm | ||
| * @return An alphabetized list of users based on Last Name, first name. Empty for no search hits | ||
| */ | ||
| public List<User> getUsersBySearchTerm(String searchTerm); |
There was a problem hiding this comment.
Consider moving this to its own dao as it is not Local Contact specific?
|
Looks good, had one suggestion (found in inline comments) to refactor search to be its own service/dao, but I consider that a non-blocking suggestion. 👍 |
|
Search service and search dao created. drops 🎤 |
|
Added #20 to address the local impl of the search service. |
vertein
force-pushed
the
mwIntegration
branch
2 times, most recently
from
a0d6f07
to
c66cd8e
Compare
Conflicts: my-profile-local-contact-impl/src/main/java/edu/wisc/my/profile/local/service/LocalContactInformationServiceImpl.java
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dao to do middleware integration for search.