This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Comment escape char #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -145,7 +146,7 @@ private static JSONObject jsonifyEmergencyContact(ContactInformation eci) { | |||
| JSONObject emergencyContact = new JSONObject(); | |||
| emergencyContact.put("EMERGENCY NAME", eci.getPreferredName()); | |||
| emergencyContact.put("RELATION", eci.getRelationship()); | |||
| emergencyContact.put("RELATION COMMENT", eci.getComments()); | |||
| emergencyContact.put("RELATION COMMENT", eci.getComments()+" "); | |||
There was a problem hiding this comment.
Should we add in a "if ends in quote then add space"? Baby concern about saving over and over will add more and more spaces.
There was a problem hiding this comment.
I had this thought too. I was on the fence and could go either way. Spaces vs computational logic. Let's do it. I'll update.
There was a problem hiding this comment.
Checked and no longer will append unlimited spaces
|
👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
