This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
MUMPFL-83 Search optionally by first name #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import edu.wisc.my.profile.model.User; | ||
|
|
||
| public interface SearchUsersService { | ||
|
|
||
| /** | ||
| * Get a list of users based on search term | ||
| * @param searchTerm | ||
| * @return an alphabetized list based on last name, first name | ||
| * @param searchTerm - |
There was a problem hiding this comment.
Looks like missing @param JavaDoc tags for username and manifestGroups.
There was a problem hiding this comment.
missing param indeed. Cleaned it up
|
👍 |
vertein
force-pushed
the
firstAndLastName
branch
from
0a25e01
to
521f7f6
Compare
|
👍 |
|
Added some labels and removed descriptive text:
|
|
👍 |
|
Much simple so minimalist. I'm glad you did this @jhanstra , I was caught in an endless loop with too much descriptive text and things were spiraling so much out of control. 👍 |
vertein
added a commit
that referenced
this pull request
Jul 24, 2015
MUMPFL-83 Search optionally by first name
|
Haha, glad I could help @vertein |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in the ability to optionally search by first name.
Before UI:
After UI:
@jhanstra has graciously volunteered to work on MUMPFL-105 to update the UI when he is available.