This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
MUMPFL-81 Cleanup phone number fields #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timlevett
commented
Jul 22, 2015
timlevett
commented
- Changes all non-zero phone numbers to optional
- Adds trash button to non-zero phone numbers
- Removes "add another" after 3 are on the screen
- Allows you to submit an empty phone number, as long as zero is filled out
- Doesn't save said zero phone number
- Doesn't show an empty phone number in the view mode
| <option value="mobile" selected="selected">Mobile</option> | ||
| <option value="home">Home</option> | ||
| <option value="work">Work</option> | ||
| <option value="other">Other</option> | ||
| </select> | ||
|
|
||
| </div> | ||
| <div class='col-xs-2 no-padding'><button aria-label="Delete Phone Number" class='btn btn-default' style='top : 25px; margin-left: 10px;' ng-click='contact.phoneNumbers.splice($index, 1)' ng-if="$index !== 0"><i class='fa fa-trash'></i></a></div> |
apetro
changed the title
|
👍 |
2 similar comments
|
👍 |
|
👍 |
timlevett
pushed a commit
that referenced
this pull request
Jul 22, 2015
MUMPFL-81 Cleanup phone number fields
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.