This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
MUMPFL-110 : Fix state country drop downs #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
timlevett
commented
Jul 27, 2015
- Country is now preselected as USA for new form
- State is now preselected as WI for new form
- Fix country order (now A-Z)
- Fix State Order (now A-Z)
- Clean up empty state ... of state when a country doesn't have state/province/regions... in our database
👍 |
1 similar comment
👍 |
<option ng-repeat='item in states | filter:{country: address.country} | orderBy:value' ng-if='address.country' value='{{item.key}}' ng-attr-selected="{{isSelection(address.state, item.key)}}">{{item.value}}</option> | ||
class="form-control" | ||
ng-model='address.state' ng-disabled='!address.country || (states | filter:{country: address.country}).length === 0'> | ||
<option ng-if='!address.country' value=''>Select Country First</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe sentence-case as "Select country first".
👍 Does it show the correct country/state when someone goes in to edit mode? |
@vertein - yes, yes it does |
timlevett
pushed a commit
that referenced
this pull request
Jul 28, 2015
MUMPFL-110 : Fix state country drop downs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.