This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
MUMPFL-86 : Add in housing RO addresses #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 . Reflecting the housing-derived-ness and hiding the edit, delete controls is better than not. I wonder if it would be even better to keep the edit, delete controls, disabled, with some kind of tooltip or other descriptive text so that if student tries to edit them they learn that by policy they cannot. |
timlevett
pushed a commit
that referenced
this pull request
Jul 30, 2015
MUMPFL-86 : Add in housing RO addresses
|
Good thought @apetro, due to time constraints I'm going to leave it as is. If we do end up doing this we will have to keep in mind that this partial is also used for the admin lookup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readOnlyontype=HOUSINGhousingthat is set to true iftype=HOUSINGfor message and add buttons