This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Students have phones too #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| JSONObject json = ContactInformationMapper.convertToJSONObject(emergencyContacts, localInfo, phNumberWithDate); | ||
| json.put("NETID", netId); | ||
| if(logger.isTraceEnabled()) { | ||
| logger.trace("Saving the following JSON: " + json.toString()); |
There was a problem hiding this comment.
slf4j enables a not-if-gated logger.trace("Saving the following JSON: {} .", json); at no meaningful performance penalty vs this syntax.
There was a problem hiding this comment.
I'll take a look. This was copy and pasted, so I might look at our other uses of this.
|
No additional suggestions from me. |
vertein
force-pushed
the
studentsHavePhonesToo
branch
2 times, most recently
from
0b58e70
to
069b7c0
Compare
vertein
force-pushed
the
studentsHavePhonesToo
branch
from
4d967df
to
cf12889
Compare
vertein
force-pushed
the
studentsHavePhonesToo
branch
from
cf12889
to
7468ca2
Compare
|
👍 This is progress, it fulfills the story, I'm entirely in favor. I do predict that we'll eventually circle back to allow multiple phone numbers, but let's ship this excellent progress and see what the reaction is. |
|
👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
New:
Clean State:
Stacks on screen size small now:
Looks like someone should add a phone number:
Looks like you need a type before clicking that save button:
State with information entered:
And you can always hit update and go back and update (but not delete):
Loading state:
