This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Materialize my-profile #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
apetro
approved these changes
Nov 8, 2016
| <p ng-if="contact.relationship">Relationship: {{ contact.relationship }}</p> | ||
| <p ng-if="contact.comments">Comments: {{ contact.comments }}</p> | ||
| <div layout="row" ng-hide="contact.readOnly" class="buttons-small"> | ||
| <md-button class="md-accent md-raised" ng-click="addEdit()">Add another</md-button> |
There was a problem hiding this comment.
In another spot, "Add another" is nuanced for screen readers with a clarifying aria-label (add another what?) Seemed like a good move?
| <compress>true</compress> | ||
| <includes> | ||
| <include>my-app.less</include> | ||
| <include>admin.less</include> |
There was a problem hiding this comment.
Noting that this is the only substantive change to pom.xml; everything else changing in pom.xml is just whitespace.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opened this PR early -- using it to keep track of progress and note anything left to do so I don't forget things day to day.
In this PR:
Note:
my-profile-webapp/pom.xmlwas included due to an accidental commit. All changes are whitespace only and can be ignoredTo do:
nameattributes andng-messageserror help text to all form inputs (backlogged: MUMPFL-145)Screenshots