Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the dependencyInjector interface in Firefox #62

Closed
willscott opened this issue Apr 17, 2014 · 1 comment
Closed

Implement the dependencyInjector interface in Firefox #62

willscott opened this issue Apr 17, 2014 · 1 comment
Labels

Comments

@willscott
Copy link
Member

Issue by Paul-E from Wed Jan 15 22:47:19 2014
Originally opened as https://github.com/UWNetworksLab/UProxy/issues/154


implement the dependencyInjector interface in Firefox

The dependencies.js file defines the dependencyInjector interface. Through the dependencyInjector interface the UI frontend in the popup talks to freedom and retrieves its model. dependencyInjector must be implemented before the UI can function.

Some things that need to be resolved:

dependencies.js location

Find a home for the dependencies.js file in firefox. Right now we get an error in the console that says: No chrome package registered for chrome://uproxy-common/scripts/dependencies.js This is because popup.html looks for dependencies.js by going two directories up.

A path of chrome://uproxy-common/scripts/... isn't possible in Firefox because chrome urls are registered in the form chrome://name/(content|skin|locale)/...

We can either change the way popup.html finds the dependencies.js file or we can put popup.html deeper in the firefox directory structure.

Implement dependencyInjector

This may need to be done after the Typescript refactor.

@willscott willscott added this to the v0.8 Allardice Feature Complete milestone Apr 17, 2014
@scouttle scouttle added P0 and removed P0 labels Apr 28, 2014
@dborkan
Copy link
Contributor

dborkan commented Oct 8, 2014

This is obsolete, we now have uProxy core and ui communicating in Firefox

@dborkan dborkan closed this as completed Oct 8, 2014
trevj pushed a commit that referenced this issue Dec 7, 2016
Ouput invite data in JSON format for installer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants