Change Google authentication to use OAuth2 flow, and allow user to pick Google account #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck Google account.
| // Client ID associated with our redirect URL from Google Developers Console. | ||
| var CLIENT_ID = | ||
| '746567772449-jkm5q5hjqtpq5m9htg9kn0os8qphra4d.apps.googleusercontent.com'; | ||
|
|
||
| function AuthGoogle(credCallback, errorCallback) { |
There was a problem hiding this comment.
AuthGoogle really looks like it wants to be a typescript class :)
|
How was it tested? :) |
|
Just one question - beyond that, code is excellent :) LGTM |
| // the same sandboxed environment used by chrome.identity.launchWebAuthFlow) | ||
| // and would be unable to pick the right account for UProxy. | ||
| // Only invoke login popup after logout has been completed (asynchronously). | ||
| this.logout(launchLoginPopup); |
There was a problem hiding this comment.
I think it's a bit better to use a promise instead of a callback for this kind of thing.
|
LGTM |
dborkan
added a commit
that referenced
this pull request
Apr 30, 2014
Change Google authentication to use OAuth2 flow, and allow user to pick Google account
trevj
added a commit
that referenced
this pull request
Dec 7, 2016
* move to unbranded firefox builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Google authentication to use OAuth2 flow, and allow user to pick Google account.
Tested through the UI by switching between several Google accounts. Each time we login we are always given the Google login screen so users can pick their account. This works the first time the user logs in after loading the app, and each time they login after clicking logout.