Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automatic-deployment] Add Automatic Deployment with GitHub Actions HowTo #1710

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

bastiW
Copy link
Contributor

@bastiW bastiW commented Jan 13, 2024

No description provided.

@nichtmax
Copy link
Member

nichtmax commented Feb 7, 2024

That's really cool, thank you!

@nichtmax
Copy link
Member

nichtmax commented Feb 7, 2024

Overall very nice! I'm not sure about Prepare Local Git Repository, do you even need this? You can edit files in the Github web interface and you're creating a new GitHub Repository later anyway. Then you write "Follow the instructions on the section …or push an existing repository from the command line", maybe just stick to one because of simplicity?

Copy link
Member

@nichtmax nichtmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things ☺️

@nichtmax nichtmax marked this pull request as draft February 7, 2024 15:54
@bastiW
Copy link
Contributor Author

bastiW commented Mar 9, 2024

@nichtmax

Overall very nice! I'm not sure about Prepare Local Git Repository, do you even need this? You can edit files in the Github web interface and you're creating a new GitHub Repository later anyway. Then you write "Follow the instructions on the section …or push an existing repository from the command line", maybe just stick to one because of simplicity?

I personally would never init a repository on the Github website. Only just small edits in documentation or readme files.

So I made it more consistent and explained how to create a new repository with the gh cli and how to push your local code to the remote.

@bastiW
Copy link
Contributor Author

bastiW commented Mar 9, 2024

@nichtmax You can recheck this PR.

I was not sure about the correct section. Is this a HOWTO or a Guide. All other guides install something on the Uberspace. In my how-to I configure something on Github. I have chosen the how-to section.

What do I need to change to see the content of the .. author_list:: on the page?

@bastiW bastiW marked this pull request as ready for review March 9, 2024 10:59
@bastiW bastiW requested a review from nichtmax March 9, 2024 11:03
@kimdiallo kimdiallo self-assigned this Mar 22, 2024
@kimdiallo kimdiallo self-requested a review March 22, 2024 20:15
Copy link
Contributor

@kimdiallo kimdiallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first of all, i love your guide! Automating deployments and thus preventing countless opportunities for manual errors or forgotten steps will help many people to avoid frustration in the first place. Thank you very much for that.
But that's precisely why it should be as simple as possible. So I hope you will forgive us for the many changes we have requested.

source/howto_automatic-deployment.rst Show resolved Hide resolved
source/howto_automatic-deployment.rst Show resolved Hide resolved
- Git
- Github CLI

Prepare Git Repository
=============
Init a new Git repository `isabells-website`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably not every reader will immediately realize that Isabell is referring to the default account here, and a repo does not necessarily have to be a website - so perhaps something like '' would be more appropriate?

source/howto_automatic-deployment.rst Show resolved Hide resolved
@kimdiallo kimdiallo merged commit 3bdc9d7 into Uberspace:main Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants