Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade from use-contractkit to react-celo #676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

silasbw
Copy link

@silasbw silasbw commented Apr 5, 2023

No description provided.

@vercel
Copy link

vercel bot commented Apr 5, 2023

@silasbw is attempting to deploy a commit to the Ubeswap Team on Vercel.

A member of the Team first needs to authorize it.

@silasbw
Copy link
Author

silasbw commented Apr 5, 2023

Sadly this doesn't make limit orders work on Valora, but it does fix the eth_signTypedData_v4 issue discussed here and moves ubeswap-interface off the deprecated use-contractkit module.

Attached console shot of the new issue:
error

@@ -107,15 +107,14 @@
},
"license": "GPL-3.0-or-later",
"resolutions": {
"@celo/wallet-walletconnect": "1.2.0",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure why this was here, but i was worried it could cause issues with react-celo (because it's such an old version), so I removed it.

@silasbw
Copy link
Author

silasbw commented Apr 6, 2023

I have a fix the issue I posted about above. Happy to send another PR after this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant