Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various updates #1

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Various updates #1

wants to merge 15 commits into from

Conversation

macalinao
Copy link

@macalinao macalinao commented May 31, 2021

Changes:

  • Adds MetaMask support
  • Adds account name to connectors
  • Adds helpers for ethers.js users

@vercel
Copy link

vercel bot commented May 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ubeswap/use-contractkit/5eRTCtEcn12NrwZWqy6pM61zEzUp
✅ Preview: https://use-contractkit-git-igm-updates-ubeswap.vercel.app

@aslawson
Copy link

aslawson commented Jun 7, 2021

Oh I also didn't realize you cleaned up mobile view as well. That was another ticket this sprint:
celo-org/celo-monorepo#7932
celo-org/celo-monorepo#7934
When I test on mobile, it always sends me to MetaMask install even when I have the mobile app downloaded...

How do you want to reconcile our changes into your library? Happy to do whatever is easiest

Hey @macalinao --

It looks like @AlexBHarley already pushed the code for the Valora changes and look like also updated the mobile version. So if its not too much trouble, if you could:

  • rebase and add the Metamask add (with updating Celo Extension Wallet image)
  • resolve issue with Mobile Metamask or remove it.

🙏🙏🙏

We can updated the Celo Docs part after merge.

 - example@0.1.1
 - @ubeswap/use-contractkit@1.0.0-ube.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants