Kotlin Generator: make CppProxy public #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make CppProxy public, so that the static method `nativeDestroy` can legally be called from the NativeObjectManager. Otherwise, this results in IllegalAccessException, for example: Exception in native cleanup of io.openmobilemaps.mapscore.shared.map.LayerInterface.CppProxy: java.lang.IllegalAccessException: class com.snapchat.djinni.NativeObjectManager$NativeObjectWrapper cannot access a member of class io.openmobilemaps.mapscore.shared.map.LayerInterface$CppProxy with modifiers "public static final native"
maurhofer-ubique
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make CppProxy public, so that the static method
nativeDestroycan legally be called from the NativeObjectManager.Otherwise, this results in IllegalAccessException, for example:
Note: the Java generator also creates the corresponding inner class as public (
public static final class CppProxy...).