Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Letter's PointSize computation #229

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Conversation

BobLd
Copy link
Collaborator

@BobLd BobLd commented Oct 12, 2020

  • fix Letter's PointSize computation by applying the transform to a rectangle of height fontSize
  • add test with rotated letters

Issue was related to https://stackoverflow.com/questions/48010235/pdf-specification-get-font-size-in-points

…ectangle of height fontSize

- add test with rotated letters
@codecov-io
Copy link

Codecov Report

Merging #229 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   64.51%   64.49%   -0.03%     
==========================================
  Files         600      600              
  Lines       39675    39666       -9     
==========================================
- Hits        25596    25582      -14     
- Misses      14079    14084       +5     
Impacted Files Coverage Δ
...UglyToad.PdfPig/Graphics/ContentStreamProcessor.cs 86.87% <100.00%> (-0.26%) ⬇️
src/UglyToad.PdfPig.Core/TransformationMatrix.cs 73.03% <0.00%> (-2.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 034e9a9...cd9ac6a. Read the comment docs.

@InusualZ
Copy link
Collaborator

Since you are fixing the calculation, you may want to fix the description too here

@BobLd
Copy link
Collaborator Author

BobLd commented Oct 12, 2020

well spotted

Copy link
Member

@EliotJones EliotJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this produces the correct results, thanks for fixing it :)

@EliotJones EliotJones merged commit d959a30 into UglyToad:master Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants