[New Feature] PdfPageBuilder: Allow to copy pages from another document #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very naive implementation, because if you copy a lot of pages from a given document you would have duplicated resources. But, I would like to get some thoughts on this implementation.
I was surprise by the amount of code that this feature needed to be implemented. I was expecting a lot more. Even so, there is some duplicated code in two parts:
IReadOnlyList<>
andIList<>
, butIReadOnlyResourceStore
andIResourceStore
. I would like yours thought about thatAnyway, This code have some
TODO
I would like to address them, but I don't know If you even want the feature in it's current path of implementation, so maybe the effort to implement them are not worth.If you have any suggestions, thought, anything feel free to comment.