Check and handle circular references when processing XObject forms and fix #671 #676
Conversation
|
@EliotJones tests are now fixed, let me know what you think about the method to handle that |
| @@ -603,6 +603,12 @@ private void ProcessFormXObject(StreamToken formStream) | |||
| // 3. We don't respect clipping currently. | |||
|
|
|||
| // 4. Paint the objects. | |||
| if (parsingOptions.UseLenientParsing && xObjectName != null && operations.OfType<InvokeNamedXObject>()?.Any(o => o.Name == xObjectName) == true) | |||
There was a problem hiding this comment.
Would this still stack overflow when parsingOptions.UseLenientParsing is false? Maybe the other branch of this if should throw an exception in that case?
There was a problem hiding this comment.
it would yes,and makes sense to throw an exception. Will update that
There was a problem hiding this comment.
I need to do further investigation in fact. MOZILLA-3136-0.pdf is flagged as having circular reference now, but was never an issue with that (it seems)
There was a problem hiding this comment.
@EliotJones I've updated the logic to also check each forms data so that MOZILLA-3136-0 is not flag as having a problem. We also now throw an exception when circular references exist
Check and handle circular references when processing XObject forms and fix #671