Update spread order (onyx-dot-app#2386)

* update spread * update
UiPath · Oct 2, 2024 · fa1eb2b · fa1eb2b
1 parent 9853347
commit fa1eb2b
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/web/src/app/admin/embeddings/pages/EmbeddingFormPage.tsx b/web/src/app/admin/embeddings/pages/EmbeddingFormPage.tsx
@@ -191,12 +191,13 @@ export default function EmbeddingForm() {
     }
     let newModel: SavedSearchSettings;
 
+    // We use a spread operation to merge properties from multiple objects into a single object.
+    // Advanced embedding details may update default values.
     if (selectedProvider.provider_type != null) {
       // This is a cloud model
       newModel = {
-        ...advancedEmbeddingDetails,
-        ...selectedProvider,
         ...rerankingDetails,
+        ...advancedEmbeddingDetails,
         model_name: selectedProvider.model_name,
         provider_type:
           (selectedProvider.provider_type
@@ -206,9 +207,9 @@ export default function EmbeddingForm() {
     } else {
       // This is a locally hosted model
       newModel = {
-        ...advancedEmbeddingDetails,
         ...selectedProvider,
         ...rerankingDetails,
+        ...advancedEmbeddingDetails,
         model_name: selectedProvider.model_name!,
         provider_type: null,
       };
@@ -225,6 +226,7 @@ export default function EmbeddingForm() {
         },
       }
     );
+
     if (response.ok) {
       setPopup({
         message: "Changed provider suceessfully. Redirecing to embedding page",