Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in docs #151

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Conversation

ChinoUkaegbu
Copy link
Contributor

@ChinoUkaegbu ChinoUkaegbu commented Nov 7, 2024

Brief Description of your Changes.

Fixes the typos in various parts of the docs. Fixes #149

Impact of your Changes

Clarity of docs.

Tests Performed

What have you done to ensure this change has the least possible impact on the project?

Additional Comments

The query intro still contains the same definition as the World intro. Not quite sure what to change it to

@Ukendio
Copy link
Owner

Ukendio commented Nov 7, 2024

It is a bit difficult for me to review the changes on the phone so I will have to leave the review to someone else for the moment until I can view it on the computer.

As for the title, there is no need to prefix with docs: or fix:. It is not a convention or anything

@Ukendio Ukendio changed the title docs: Fix typos in docs Fix typos in docs Nov 7, 2024
Copy link
Collaborator

@EncodedVenom EncodedVenom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but some clarification on this one section would go a long way.

docs/learn/concepts/component-traits.md Outdated Show resolved Hide resolved
docs/learn/concepts/component-traits.md Outdated Show resolved Hide resolved
@Ukendio Ukendio merged commit 46f99a5 into Ukendio:main Nov 17, 2024
2 of 3 checks passed
@ChinoUkaegbu
Copy link
Contributor Author

Btw the query intro still contains the same definition as the World intro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various typos
3 participants