SpTxSquashedV1: simplify txid #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got rid of the tx artifacts hash. The reason for it was a follows: ``` note: key images are represented in the tx id twice (tx proposal prefix and input images - // - the reasons are: A) decouple proposals from the enote image structure, B) don't require proposals to commit - // to input commitment masks ``` Input proposals DO commit to input commitment masks though (see `SpInputProposalCore`). Does the txid hash indirection still serve a purpose or could we make the txid faster?
|
This PR is invalid because it doesn't move commitment to
They don't commit to the masks, since proposals with different masks produce the same proposal id. I don't remember the full context around this, but more flexibility in the tx id structure is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got rid of the tx artifacts hash. The reason for it was a follows:
Input proposals DO commit to input commitment masks though (see
SpInputProposalCore). Does the txid hash indirection still serve a purpose or could we make the txid faster?