Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken WithResumePreviousScan function #61

Closed
1 task done
elivlo opened this issue Nov 10, 2020 · 2 comments
Closed
1 task done

Broken WithResumePreviousScan function #61

elivlo opened this issue Nov 10, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@elivlo
Copy link
Collaborator

elivlo commented Nov 10, 2020 •
edited
Loading

  • I'm submitting a ...
    • bug report

  • Current behavior:
    When running s scan with WithResumePreviousScan("testfilename") function, the nmap scan won't start.
    grafik
    grafik

  • What is the output from nmap directly?
    grafik

  • What needs to be changed to work properly?

  1. Remove all arguments except --resume <filename>
    grafik

  2. Reload the current file content in front of the resuming nmap xml output...
    grafik
    ... because it will only append new xml and does not starting from beginning.
    grafik
@Ullaakut
Copy link
Owner

Nice, I never used that feature so I didn't know. We can indeed add a check in the Run methods to not add the XML options if the Resume option is set :)

@Ullaakut Ullaakut added enhancement New feature or request good first issue Good for newcomers bug Something isn't working and removed enhancement New feature or request labels Nov 10, 2020
ohDaddyPlease added a commit to ohDaddyPlease/nmap that referenced this issue Jan 21, 2021
@ohDaddyPlease
Ullaakut#61: fix --resume opt
9fc16db
@ohDaddyPlease ohDaddyPlease mentioned this issue Jan 21, 2021
Merged
Ullaakut pushed a commit that referenced this issue Jan 25, 2021
@ohDaddyPlease
#61: fix --resume opt (#68)
cc17edc
@elivlo
Copy link
Collaborator Author

elivlo commented Jan 27, 2021

Nice! Thank you @ohDaddyPlease

@elivlo elivlo closed this as completed Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ullaakut @elivlo