Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xml.go #13

Merged
merged 2 commits into from
May 27, 2019
Merged

Update xml.go #13

merged 2 commits into from
May 27, 2019

Conversation

blshkv
Copy link
Contributor

@blshkv blshkv commented May 27, 2019

use low case of Ullaakut. That seems to be the case everywhere else

use low case of ```Ullaakut```. That seems to be the case everywhere else
@Ullaakut
Copy link
Owner

I pushed an attempt to fix it, that should make the CI happy and we'll be able to merge this quickly :)

@Ullaakut Ullaakut self-assigned this May 27, 2019
@Ullaakut Ullaakut added the bug Something isn't working label May 27, 2019
@Ullaakut
Copy link
Owner

I think the reason the CI breaks is just because it clones the repo in github.com/Ullaakut/nmap instead of github.com/ullaakut/nmap and there's nothing I can do about this afaik. I'll disable travis until I sort this out and merge this PR. Thanks @blshkv

@Ullaakut Ullaakut merged commit 69cba68 into Ullaakut:master May 27, 2019
@blshkv
Copy link
Contributor Author

blshkv commented May 27, 2019

Yes, indeed. It calls:
git clone --depth=50 https://github.com/Ullaakut/nmap.git Ullaakut/nmap
it must be a workaround for this problem.

@blshkv
Copy link
Contributor Author

blshkv commented May 27, 2019

Do not forget to update:
https://github.com/Ullaakut/cameradar/blob/master/go.mod
as well. Could it be the reason of this call?

@Ullaakut
Copy link
Owner

It's not needed. Basically as you can see in this file, there is a direct import to ullaakut/nmap and an indirect one to Ullaakut/nmap which is indirect because it's ullaakut/nmap that's importing Ullaakut/nmap. Now that it's no longer the case, the next time I update dependencies, this will be removed. But it's not necessary to add a commit just for this, as the current commit works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants