RunAsync function with supporting struct changes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Sep 4, 2019
Ullaakut
requested changes
Sep 4, 2019
Formatting errs as suggested Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Formatting errs as suggested Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Spelling/Grammer Fixes Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Spelling/Grammer Fixes Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Code formatting fixes Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Moving var definitions into groups Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Code formatting fixes Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
Code formatting fixes. Updating import statements for lowercasing standards Co-Authored-By: Brendan Le Glaunec <brendan.le-glaunec@epitech.eu>
golangcibot
reviewed
Sep 4, 2019
Ullaakut
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains code changes to support RunAsync methods to allow for real time updates from the NMAP process. It is currently able to spit out XML results to the screen.
Fixes #6
TESTS
Still need to be created.
BUG
When running in Async if you hit enter, it pulls a progress update from the the Nmap command. This is not intentional. I need to research into whether is is due to using bufio some how or what is cause this.
If
scanner.GetStdoutorscanner.GetStderrorscanner.Waitare called before the commandscanner.RunAsyncis ran, errors will occur. This may be the reason channels are a better approach.@Ullaakut Thoughts?
FUTURE
Look into creating a custom XML Decoder to read XML as it is received. This would allow realtime updates to be converted into structs for better manipulation.