-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes shader creation with Ubuntu+nvidia #131
Conversation
I do think this needs a tiny platform dependeny check, as on linux adding this is most likely fine (as the package is easy to install) but on Mac and Windows adding python-opengl as a dependency isn't that great. (And it will possibly break "angle" support on windows) |
Hmm, the problem I have with this is that it is an Ubuntu-specific bug that we are now solving by adding a global dependency. A simple platform.system() == "Linux" check would at least reduce it to "just" Linux but for Fedora or Arch users that would still introduce an additional dependency. Ideally this would just be fixed upstream, but until it is I would be fine with introducing this workaround as long as it is limited to Ubuntu/Debian based systems. |
I will remake the patch. Thanks |
Think something like
|
For any reason this problem seems to be Ubuntu-specific and is also present since pyqt4. * Updated the Ultimaker#131 pull request and added platform.linux_distribution to check for "Ubuntu" * Added notice about the bug report above the if-clause * Added comment why <platform.system() == "Linux"> is needed
This problem occurred to me after I installed NVDIA driver. Thanks to the answers above, I found it easy to deal with.
|
I'll test it today. |
This fixes issue #88 with Ubuntu + nvidia