Avoid Actions.qml cyclic dependency #19654
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
qt.qml.typeresolution.cycle: Cyclic dependency detected between "File:///Cura/resources/qml/Actions.qml" and "file:///Cura/resources/qml/Actions.qml"
Create a different namespace for Actions to import that has the dependencies it needs, but one that Actions isn't already part of.
While this solution works, I don't know what is extra special about Actions.qml that it can't import Cura without "Cyclic dependency detected" and other components like Menus/MaterialMenu.qml which is registered in cura/CuraApplication.py as a part of
qmlRegisterType(QUrl.fromLocalFile(path), "Cura", 1, 0, type_name)
, but it seems to be okay.Type of change
How Has This Been Tested?
Test Configuration:
Checklist: